提交 7eba35ac 作者: 方治民

chore: 优化 IdsParam 参数类

上级 f8e49f1d
...@@ -19,7 +19,6 @@ import com.yiring.common.validation.group.Group; ...@@ -19,7 +19,6 @@ import com.yiring.common.validation.group.Group;
import com.yiring.common.vo.PageVo; import com.yiring.common.vo.PageVo;
import io.swagger.v3.oas.annotations.Operation; import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.tags.Tag; import io.swagger.v3.oas.annotations.tags.Tag;
import java.io.Serializable;
import java.util.*; import java.util.*;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j; import lombok.extern.slf4j.Slf4j;
...@@ -91,8 +90,7 @@ public class RoleController { ...@@ -91,8 +90,7 @@ public class RoleController {
Role entity = RepositoryUtil.find(roleRepository, idParam.getId()); Role entity = RepositoryUtil.find(roleRepository, idParam.getId());
// 查询权限集合 // 查询权限集合
Collection<Serializable> ids = idsParam.toIds(); Set<Permission> permissions = new HashSet<>(permissionRepository.findAllById(idsParam.toIds()));
Set<Permission> permissions = new HashSet<>(permissionRepository.findAllById(ids));
entity.setPermissions(permissions); entity.setPermissions(permissions);
roleRepository.saveAndFlush(entity); roleRepository.saveAndFlush(entity);
return Result.ok(); return Result.ok();
......
...@@ -17,8 +17,6 @@ import com.yiring.common.utils.Specifications; ...@@ -17,8 +17,6 @@ import com.yiring.common.utils.Specifications;
import com.yiring.common.vo.PageVo; import com.yiring.common.vo.PageVo;
import io.swagger.v3.oas.annotations.Operation; import io.swagger.v3.oas.annotations.Operation;
import io.swagger.v3.oas.annotations.tags.Tag; import io.swagger.v3.oas.annotations.tags.Tag;
import java.io.Serializable;
import java.util.Collection;
import java.util.HashSet; import java.util.HashSet;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
...@@ -62,8 +60,7 @@ public class UserController { ...@@ -62,8 +60,7 @@ public class UserController {
User entity = RepositoryUtil.find(userRepository, idParam.getId()); User entity = RepositoryUtil.find(userRepository, idParam.getId());
// 查询角色集合 // 查询角色集合
Collection<Serializable> ids = idsParam.toIds(); Set<Role> roles = new HashSet<>(roleRepository.findAllById(idsParam.toIds()));
Set<Role> roles = new HashSet<>(roleRepository.findAllById(ids));
entity.setRoles(roles); entity.setRoles(roles);
userRepository.saveAndFlush(entity); userRepository.saveAndFlush(entity);
return Result.ok(); return Result.ok();
......
...@@ -6,9 +6,9 @@ import io.swagger.v3.oas.annotations.media.Schema; ...@@ -6,9 +6,9 @@ import io.swagger.v3.oas.annotations.media.Schema;
import jakarta.validation.constraints.NotBlank; import jakarta.validation.constraints.NotBlank;
import java.io.Serial; import java.io.Serial;
import java.io.Serializable; import java.io.Serializable;
import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
import java.util.stream.Collectors; import java.util.Collections;
import java.util.Set;
import lombok.*; import lombok.*;
import lombok.experimental.FieldDefaults; import lombok.experimental.FieldDefaults;
...@@ -32,7 +32,7 @@ public class IdsParam implements Serializable { ...@@ -32,7 +32,7 @@ public class IdsParam implements Serializable {
@Parameter(description = "ids 多个以逗号分割", example = "1,2") @Parameter(description = "ids 多个以逗号分割", example = "1,2")
@NotBlank @NotBlank
String ids; Set<String> ids;
/** /**
* 获取 String 类型的 ID 集合 * 获取 String 类型的 ID 集合
...@@ -40,6 +40,6 @@ public class IdsParam implements Serializable { ...@@ -40,6 +40,6 @@ public class IdsParam implements Serializable {
* @return ID 集合 * @return ID 集合
*/ */
public Collection<Serializable> toIds() { public Collection<Serializable> toIds() {
return Arrays.stream(this.ids.split(",")).collect(Collectors.toSet()); return Collections.unmodifiableSet(ids);
} }
} }
Markdown 格式
0%
您添加了 0 到此讨论。请谨慎行事。
请先完成此评论的编辑!
注册 或者 后发表评论